Ensure inferred let pattern types are well-formed - #160874
Closed
s7tya wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This PR changes a file inside |
rustbot
added
S-waiting-on-review
Contributor
|
Closing, see #157841 (comment) |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150040
Context: Same as #157013, but that PR was merged without a crater run and FCP, so it was reverted and #157841 was opened instead. However, there is a snippet that causes an ICE, which I reported in #150040 (comment), specifically in
tests/crashes/150040.rs. This caused the CI to fail because the root cause was fixed in the original PR and it no longer causes an ICE. This PR removes that crash test case in addition to the previous changes, as it is already covered by the newly added tests.I don't know how the FCP process works, so if it's problematic to open a different PR from the one where the FCP has finished, please just ignore this and remove
tests/crashes/150040.rsin #157841 instead.r? lcnr